Adding friendlier exception if no S3 config provided #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oavdeev
reviewed
Dec 8, 2021
| raise MetaflowS3URLException( | ||
| "No config or correct S3 root path provided when trying to use S3 storage" | ||
| ) | ||
|
|
There was a problem hiding this comment.
why only check this inside the if run.. if not prefix.. ?
There was a problem hiding this comment.
It is only used in the if run portion so IMHO, it could be checked there. I would also check it in get_root_from_config (used for IncludeFile).
There was a problem hiding this comment.
@exotikh3 Can you address this comment so that we can proceed with the merge?
|
@romain-intel please review latest changes |
|
I recently stumbled across this issue, so it seems like it still requires a fix. Given the PR is now pretty old (over 18 months) is there any objection to me starting a new one? @savingoyal That is ok with you? |
|
closing as this got superseded by another PR which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code that tries to resolve this issue #683
Looking forward for any kind of feedback as this is my first contribution to Metaflow